test(e2e): cover dependent wake-up after land - #690
Merged
behinddwalls merged 1 commit intoSep 11, 2026
Conversation
This was referenced Sep 8, 2026
behinddwalls
marked this pull request as ready for review
September 8, 2026 05:22
behinddwalls
force-pushed
the
preetam/land-wakeup-e2e
branch
from
September 10, 2026 16:35
6b21acd to
5de590f
Compare
sbalabanov
approved these changes
Sep 10, 2026
behinddwalls
force-pushed
the
preetam/land-wakeup-e2e
branch
from
September 11, 2026 05:22
5de590f to
03fdfc1
Compare
## Summary ### Why? A dependent batch waiting on a successful predecessor must be replanned when that predecessor lands. Other queue activity can mask a dropped wake-up, leaving this edge without deterministic regression coverage. ### What? Add an E2E fixture that parks the leading land, funds only the dependent's success-assumption path, and verifies the land result fan-out is the event that wakes and lands the dependent. ## Test Plan - ✅ `./tool/bazel test //test/e2e/submitqueue:go_default_test --test_filter='TestE2EIntegration/TestDependentBatch_IsWokenByTheLandAhead' --test_output=errors --sandbox_writable_path=\"$HOME/.docker\"`
behinddwalls
force-pushed
the
preetam/land-wakeup-e2e
branch
from
September 11, 2026 05:35
03fdfc1 to
a2a7f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
A dependent batch waiting on a successful predecessor must be replanned when that predecessor lands. Other queue activity can mask a dropped wake-up, leaving this edge without deterministic regression coverage.
What?
Add an E2E fixture that parks the leading land, funds only the dependent's success-assumption path, and verifies the land result fan-out is the event that wakes and lands the dependent.
Test Plan
./tool/bazel test //test/e2e/submitqueue:go_default_test --test_filter='TestE2EIntegration/TestDependentBatch_IsWokenByTheLandAhead' --test_output=errors --sandbox_writable_path=\"$HOME/.docker\"