Skip to content

refactor: separate land workflow from runway merge - #689

Merged
behinddwalls merged 1 commit into
mainfrom
preetam/land-terminology-core
Sep 11, 2026
Merged

refactor: separate land workflow from runway merge#689
behinddwalls merged 1 commit into
mainfrom
preetam/land-terminology-core

Conversation

@behinddwalls

@behinddwalls behinddwalls commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Why?

SubmitQueue owns the user-facing land workflow, while Runway owns the merge execution contract. Keeping those terms distinct makes the service boundary explicit without renaming Runway's published contract.

What?

Rename SubmitQueue lifecycle states, controllers, internal topics, and their tests to land terminology. Preserve Runway MergeRequest, MergeStep, MergeResult, merge controllers, extensions, configuration, and merge topic names, with translation at the validation, land-dispatch, and result-signal boundaries.

Preserve every merge strategy mapping, including PROMOTE.

Test Plan

  • make gazelle
  • make test

@behinddwalls
behinddwalls marked this pull request as ready for review September 8, 2026 03:52
@behinddwalls
behinddwalls requested review from a team and sbalabanov as code owners September 8, 2026 03:52
@behinddwalls
behinddwalls force-pushed the preetam/land-terminology-core branch from efec5d1 to 2637121 Compare September 8, 2026 05:21
Base automatically changed from preetam/land-delete-mergechecker to main September 10, 2026 16:35
@behinddwalls
behinddwalls force-pushed the preetam/land-terminology-core branch from 2637121 to ed06d7c Compare September 10, 2026 16:35
Comment thread test/e2e/submitqueue/git_suite_test.go
@behinddwalls
behinddwalls force-pushed the preetam/land-terminology-core branch from ed06d7c to ba668a6 Compare September 11, 2026 05:22
## Summary

### Why?

SubmitQueue owns the user-facing land workflow, while Runway owns the merge execution contract. Keeping those terms distinct makes the service boundary explicit without renaming Runway's published contract.

### What?

Rename SubmitQueue lifecycle states, controllers, internal topics, and their tests to land terminology. Preserve Runway `MergeRequest`, `MergeStep`, `MergeResult`, merge controllers, extensions, configuration, and merge topic names, with translation at the validation, land-dispatch, and result-signal boundaries.

Preserve every merge strategy mapping, including `PROMOTE`.

## Test Plan

- ✅ `make gazelle`
- ✅ `make test`
@behinddwalls
behinddwalls force-pushed the preetam/land-terminology-core branch from ba668a6 to b900aec Compare September 11, 2026 05:35
@behinddwalls
behinddwalls added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 7971cd3 Sep 11, 2026
15 checks passed
@behinddwalls
behinddwalls deleted the preetam/land-terminology-core branch September 11, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants