fix/batches: reject Git metadata in repository archives - #1366
Merged
cbrnrd merged 1 commit intoSep 3, 2026
Merged
Conversation
BolajiOlajide
approved these changes
Sep 3, 2026
cbrnrd
deleted the
carterbrainerd-vuln-142-a-repository-archive-containing-githookspre-commit-achieves
branch
September 3, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This was brought to our attention via HackerOne.
A repository archive could include a
.gitdirectory. During bind workspace setup, src extracted this directory and then ran Git commands on the host. Malicious Git hooks or repository configuration could therefore run code on the host.Solution
Reject archive entries that resolve inside the root
.gitdirectory. The check also handles normalized paths and case-insensitive filesystems.Verification Evidence
go test ./internal/batches/workspacego test ./internal/batches/...