fix/batches: prevent repository archives from enabling Git hooks - #1367
Merged
cbrnrd merged 1 commit intoSep 3, 2026
Conversation
cbrnrd
marked this pull request as ready for review
September 3, 2026 17:47
BolajiOlajide
approved these changes
Sep 3, 2026
cbrnrd
force-pushed
the
carterbrainerd-vuln-146-i-can-turn-committed-backslash-filenames-into-host-git-hooks
branch
from
September 3, 2026 17:57
38256df to
d228bd5
Compare
cbrnrd
enabled auto-merge (squash)
September 3, 2026 18:00
cbrnrd
deleted the
carterbrainerd-vuln-146-i-can-turn-committed-backslash-filenames-into-host-git-hooks
branch
September 3, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This issue was brought to our attention via HackerOne.
On Windows, Git repository archive names can contain backslashes that are treated as directory separators during extraction. This can place repository files in Git metadata paths and allow a host-side Git hook to run before the batch step starts.
Solution
Reject archive names that contain backslashes before extracting any files. Also disable hooks for every host-side Git command as a second layer of protection.
This change is intended to merge after #1366, which rejects archive entries that resolve to
.gitpaths.Verification Evidence
go test ./internal/batches/...GOOS=windows GOARCH=amd64 go test -c ./internal/batches/workspace