Skip to content

test: avoid orphaned child on Windows abort test #65451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PickBas wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

test: avoid orphaned child on Windows abort test #65451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/parallel/test-child-process-exec-abortcontroller-promisified.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ const invalidArgTypeError = {
name: 'TypeError'
};

const waitCommand = common.isWindows ?
// `"` is forbidden for Windows paths, no need for escaping.
`"${process.execPath}" -e "setInterval(()=>{}, 99)"` :
'sleep 2m';
// `pause` is a cmd.exe builtin, so killing the shell kills the whole tree.
// Running an executable here would leave it orphaned.
const waitCommand = common.isWindows ? 'pause' : 'sleep 2m';

{
const ac = new AbortController();
Expand Down
Loading