test: avoid orphaned child on Windows abort test - #65451
Open
PickBas wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#58118 Signed-off-by: PickBas <sayed.kirill@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65451 +/- ##
==========================================
+ Coverage 90.12% 90.14% +0.01%
==========================================
Files 752 752
Lines 252325 252315 -10
Branches 47456 47454 -2
==========================================
+ Hits 227407 227437 +30
+ Misses 16217 16181 -36
+ Partials 8701 8697 -4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
test-child-process-exec-abortcontroller-promisifiedcan leave straynode.exeprocesses behind after the test exits.exec()runs the command throughcmd.exe, andcmd.execannot replace itself with the command it runs, so thenode.exestarted for-e "setInterval(()=>{}, 99)"is a grandchild.child.kill()terminates only the direct child, leaving that grandchild orphaned if the kill lands aftercmd.exehas already created it. This is timing-dependent and does not reproduce on every machine.Fix
Use the
cmd.exebuiltinpauseas the wait command. It blocks on the stdin pipe thatexec()opens and spawns no process of its own, socmd.exeis the only process in the tree and killing it leaves nothing behind.Fixes: #58118