Skip to content

Fail fast on head identifier in syntax-tree class #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackfirth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fail fast on head identifier in syntax-tree class #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions default-recommendations/private/syntax-tree.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@
#:attributes ([leaf 1] rank)
#:commit

(pattern (id:id subtree ...)
;; The head identifier is checked before the subtrees are recursively parsed, so that forms whose
;; head isn't the branch identifier fail fast instead of paying to descend the entire subtree only
;; to be rejected afterward (see issue #800).
(pattern ((~and id:id (~fail #:unless (free-identifier=? #'id branch-identifier))) subtree ...)
#:declare subtree (syntax-tree branch-identifier)
#:when (free-identifier=? #'id branch-identifier)
#:cut
#:with (leaf ...) #'(subtree.leaf ... ...)
#:attr rank (add1 (option-get (transduce (attribute subtree.rank) #:into (into-max)) 0)))
Expand Down
Loading