Fail fast on head identifier in syntax-tree class#810
Open
jackfirth wants to merge 1 commit into
Open
Conversation
Check the branch identifier before recursively parsing subtrees, so forms whose head isn't the branch identifier no longer descend the entire subtree only to be rejected afterward. Fixes #800 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and found no issues.
Contributor
|
Docs preview: https://resyntax.notjack.space/preview/810/ |
|
coverage: 95.319%. remained the same — fix-800-flattening-perf into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800.
The
syntax-treeclass parsed every subform recursively before checking the head identifier, so the four flattening rules descended entire subtrees only to reject most forms afterward. Moving thefree-identifier=?check ahead of the subtree parse lets non-matching forms fail immediately.