[Java] Align inline tool docs with final lambda API and ADR links

[Copilot]

Phase 4.6 focused on documentation parity for Java tool-as-lambda ergonomics: README examples and ADR-006 needed to reflect the shipped API surface and cross-reference the ADR chain clearly. This updates Java docs to match final inline tool definitions (from* factories, Param<T>, and fluent modifiers) and completes the implementation-plan bookkeeping.

• README: inline lambda tool authoring

  • Added a concise section for experimental inline tools with ToolDefinition.from(...).
  • Documented Param.of(...) required/default behavior and fluent option modifiers (skipPermission, defer, overridesBuiltInTool).
  • Included ToolInvocation-aware inline example and pointed to ADR-006 for design context.

• ADR-006: final API name/usage alignment

  • Replaced outdated pseudo-DSL example (Params.of / ParamDef) with actual API (Param.of).
  • Clarified ADR-005 references using final annotation/API names (@CopilotToolParam, ToolDefinition.fromObject(...)).
  • Added explicit cross-link to ADR-005 and noted README coverage of the final factory family.

• Plan bookkeeping

  • Marked Phase 4.6 as complete in the implementation plan file.

ToolDefinition search = ToolDefinition
    .from(
        "search_items",
        "Searches indexed items by keyword",
        Param.of(String.class, "keyword", "Search keyword"),
        keyword -> "Searching for: " + keyword)
    .skipPermission(true)
    .defer(ToolDefer.AUTO);

[edburns]

@copilot CRITICAL: Your branch was created from the wrong base. You MUST rebase your branch onto edburns/1810-java-tool-ergonomics-tool-as-lambda immediately. The plan files and context referenced in issue #1884 only exist on edburns/1810-java-tool-ergonomics-tool-as-lambda. Run: git rebase origin/edburns/1810-java-tool-ergonomics-tool-as-lambda and force-push. Do this BEFORE any other work.

Dismissing - base branch already fixed via PR edit.

[edburns]

@copilot The PR base branch has been corrected to edburns/1810-java-tool-ergonomics-tool-as-lambda. Please continue working on this PR. Your task is described in issue #1884: update Java docs and ADR cross-links for the tool-as-lambda feature. The plan files you need are on the base branch. Please rebase your branch onto origin/edburns/1810-java-tool-ergonomics-tool-as-lambda and then complete the documentation updates described in the issue checklist.

[Copilot]

@copilot The PR base branch has been corrected to edburns/1810-java-tool-ergonomics-tool-as-lambda. Please continue working on this PR. Your task is described in issue #1884: update Java docs and AD...

Completed in commit cf82a90. Documentation updates include:

• Java README now has a complete inline lambda tools section with ToolDefinition.from(...), Param.of(...), and fluent modifiers
• ADR-006 updated to reflect final API names (Param.of instead of Params.of/ParamDef)
• ADR-006 now cross-references ADR-005 and notes README coverage
• Phase 4.6 marked complete in the implementation plan

Note: mvn spotless:apply couldn't run due to network issues, but Spotless only formats Java code (not Markdown), so the documentation-only changes don't require it.

[Copilot]

Pull request overview

Updates Java documentation to match the shipped “tool-as-lambda” API surface (inline ToolDefinition.from* factories, Param<T> metadata, and fluent modifiers), plus tightens ADR cross-references and marks Phase 4.6 documentation work as complete.

Changes:

• Added a new experimental README section documenting inline lambda tool definitions and key factory variants (from*, from*WithToolInvocation).
• Updated ADR-006 to use the final API names (Param.of, @CopilotToolParam, ToolDefinition.fromObject(...)) and explicitly list the implemented factory family.
• Marked Phase 4.6 documentation updates as completed in the implementation plan.

Show a summary per file

File	Description
java/README.md	Adds inline lambda tool docs/examples and lists fluent modifiers.
java/docs/adr/adr-006-tool-definition-inline.md	Aligns ADR examples and terminology with the final shipped API and links ADR-005.
1810-java-tool-ergonomics-tool-as-lambda-remove-before-merge/1810-ignorance-reduction-for-implementation-plan.md	Updates Phase 4.6 checkbox to completed.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Low

[Copilot]

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 0 new
• Review effort level: Low