Skip to content

fix(compose): Update isImportantForBounds to return true #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 3 commits into from
Jul 20, 2026
+6 −7
Merged

fix(compose): Update isImportantForBounds to return true #5789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
454cb87
fix(compose): Update isImportantForBounds to return true
markushi Jul 20, 2026
d56def8
Update CHANGELOG
markushi Jul 20, 2026
5d0bd86
Format code
getsentry-bot Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- Backfill release, environment, distribution, tags, and app version/build—and use the matching replay-on-error sample rate—for `ApplicationExitInfo` ANR and native crash events captured before SDK initialization, without reusing options cached by a later app update ([#5762](https://github.com/getsentry/sentry-java/pull/5762))
- `SentryTagModifierNode.isImportantForBounds` now matches the default behavior and returns `true` ([#5789](https://github.com/getsentry/sentry-java/pull/5789))

## 8.49.0

Expand Down
12 changes: 5 additions & 7 deletions sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryModifier.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,14 @@

override fun SemanticsPropertyReceiver.applySemantics() {
this[SentryTag] = tag
}

Check warning on line 55 in sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryModifier.kt

View check run for this annotation

@sentry/warden / warden: check-code-attribution

⚠️ Missing copyright line in vendored file header 

**io.sentry.compose.SentryModifier** — The file is marked as vendored (`// Based on TestTag`) but has no copyright line in its header. A copyright line (e.g. `Copyright (c) <year> The Android Open Source Project`) is a required attribution field and must be present alongside the existing vendoring origin phrase and source URL.
Comment thread
markushi marked this conversation as resolved.

// SemanticsModifierNode.isImportantForBounds() was added as an abstract method in
// compose-ui 1.11. Classes compiled against earlier versions lack this method in
// compose-ui 1.11. Classes compiled against earlier versions lack this method in
// their bytecode, which causes AbstractMethodError when the accessibility tree is
// traversed on 1.11+ runtimes. We can't use the `override` keyword here because
// the method doesn't exist in the compile-time dependency (compose-ui 1.6.x), but
// the JVM satisfies the abstract-method requirement at runtime via signature
// matching. SentryTagModifierNode only stores a semantic tag and has no visual
// effect on layout, so it is not important for bounds.
@Suppress("unused") fun isImportantForBounds(): Boolean = false
// traversed on 1.11+ runtimes.
// Returning true to match the default behavior
// https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/SemanticsModifierNode.kt;l=69-83;drc=bd7809b4bc9205721c2f1bc681694dd348885849
@Suppress("unused") fun isImportantForBounds(): Boolean = true
}
}
Loading