Skip to content

fix(compose): Update isImportantForBounds to return true#5789

Merged
markushi merged 3 commits into
mainfrom
fix/compose-isImportantForBounds
Jul 20, 2026
Merged

fix(compose): Update isImportantForBounds to return true#5789
markushi merged 3 commits into
mainfrom
fix/compose-isImportantForBounds

Conversation

@markushi

Copy link
Copy Markdown
Member

As any inner node could be important for semantics. This also matches the default behavior
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/SemanticsModifierNode.kt;l=69-83;drc=bd7809b4bc9205721c2f1bc681694dd348885849

📜 Description

Fixes isImportantForBounds

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

As any inner node could be important for semantics.
@sentry

sentry Bot commented Jul 20, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.49.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 325.38 ms 375.31 ms 49.92 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5b1a06b 310.56 ms 362.79 ms 52.22 ms
ad8da22 339.92 ms 407.37 ms 67.45 ms
d15471f 307.28 ms 381.85 ms 74.57 ms
2195398 345.88 ms 411.71 ms 65.82 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
abfcc92 304.04 ms 370.33 ms 66.29 ms
22f4345 312.78 ms 347.40 ms 34.62 ms
d15471f 304.55 ms 408.43 ms 103.87 ms
ad8da22 362.98 ms 453.94 ms 90.96 ms
bbc35bb 298.53 ms 372.17 ms 73.64 ms

App size

Revision Plain With Sentry Diff
5b1a06b 0 B 0 B 0 B
ad8da22 1.58 MiB 2.29 MiB 719.83 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
2195398 0 B 0 B 0 B
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
abfcc92 1.58 MiB 2.13 MiB 557.31 KiB
22f4345 1.58 MiB 2.29 MiB 719.83 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ad8da22 1.58 MiB 2.29 MiB 719.83 KiB
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB

Previous results on branch: fix/compose-isImportantForBounds

Startup times

Revision Plain With Sentry Diff
b4e5b97 321.86 ms 372.94 ms 51.08 ms

App size

Revision Plain With Sentry Diff
b4e5b97 0 B 0 B 0 B

@runningcode runningcode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markushi
markushi merged commit eb1a946 into main Jul 20, 2026
71 checks passed
@markushi
markushi deleted the fix/compose-isImportantForBounds branch July 20, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SentryModifier.sentryTag reports zero bounds with Telephoto ZoomableImage on Sentry Android 8.47.0

4 participants