Skip to content

Allow using unsecure Node version for CI #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flamefire wants to merge 2 commits into from
Closed

Allow using unsecure Node version for CI #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3526d55
Allow using unsecure Node version for CI
Flamefire Sep 10, 2026
eef70ad
Fix C&P mistake in CI step name
Flamefire Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ env:
GIT_FETCH_JOBS: 8
NET_RETRY_COUNT: 5
DEFAULT_BUILD_VARIANT: debug,release
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

@mborland mborland Sep 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work anymore in less than 2 weeks: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

@Flamefire Flamefire Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I have #157 already done. However that was having a few issues and the latest CI builds with the current config are expired. So wanted to have at least one "original" run to compare although most issues seem to be only discovered by better test coverage (new compilers, code coverage on Windows, sanitizers)
Due to the failing CI my other PRs cannot be tested either.

So this 1-line change is just meant to buy some time for that.

Feel free to close this and merge the other one which I'd prefer.


jobs:
posix:
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,11 @@ jobs:
run: ci/github/codecov.sh "setup"

- name: Run tests
if: '!matrix.coverity'
run: ci/build.sh

- name: Upload coverage
- name: Collect coverage
if: matrix.coverage
run: ci/codecov.sh "upload"
env:
BOOST_CI_CODECOV_IO_UPLOAD: skip
run: ci/codecov.sh "collect"

- name: Upload coverage
if: matrix.coverage
Expand Down
Loading