Skip to content

Allow using unsecure Node version for CI - #162

Closed
Flamefire wants to merge 2 commits into
boostorg:developfrom
Flamefire:gha-node-workaround
Closed

Allow using unsecure Node version for CI#162
Flamefire wants to merge 2 commits into
boostorg:developfrom
Flamefire:gha-node-workaround

Conversation

@Flamefire

Copy link
Copy Markdown
Contributor

Workaround until #157 can be merged

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.79%. Comparing base (8a32a16) to head (eef70ad).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #162   +/-   ##
========================================
  Coverage    95.79%   95.79%           
========================================
  Files          117      117           
  Lines         7664     7664           
========================================
  Hits          7342     7342           
  Misses         322      322           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a32a16...eef70ad. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/ci.yml
GIT_FETCH_JOBS: 8
NET_RETRY_COUNT: 5
DEFAULT_BUILD_VARIANT: debug,release
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flamefire Flamefire Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I have #157 already done. However that was having a few issues and the latest CI builds with the current config are expired. So wanted to have at least one "original" run to compare although most issues seem to be only discovered by better test coverage (new compilers, code coverage on Windows, sanitizers)
Due to the failing CI my other PRs cannot be tested either.

So this 1-line change is just meant to buy some time for that.

Feel free to close this and merge the other one which I'd prefer.

@mborland

Copy link
Copy Markdown
Member

This repo doesn't have Drone setup for it yet so maybe that's the better option at this point? Drop everything that does not support actions v6 from GitHub Actions and add them to Drone instead.

@Flamefire

Flamefire commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Drone can be added additionally for redundancy. The reusable workflow from Boost.CI is intended to keep GHA running and updated without each repo having to do the same work.
And I do like the status display from GHA much more with each check shown individually.

Quick check: About half (15/33) of the GHA CI checks would need to be removed or updated and all the used actions too

Anyway: Why not merge this now?
Currently CI does not work.
With this CI works for 2 weeks more and that line can be removed again when you get to #157 or switch to drone if you prefer that

I just added the workaround used by Boost.CI in #163 if you prefer that as an (intermediate) solution

@Flamefire

Copy link
Copy Markdown
Contributor Author

Closing in favor of #163 for a workaround. But I suggest using #157

@Flamefire Flamefire closed this Sep 11, 2026
@Flamefire
Flamefire deleted the gha-node-workaround branch September 11, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants