Fix stream ops for RNG instances - #156
Merged
Merged
Conversation
Flamefire
force-pushed
the
stream-op
branch
2 times, most recently
from
September 12, 2026 17:51
f2d641b to
a1d303f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
===========================================
- Coverage 95.79% 95.79% -0.01%
===========================================
Files 117 117
Lines 7660 7652 -8
===========================================
- Hits 7338 7330 -8
Misses 322 322
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
mborland
approved these changes
Sep 13, 2026
mborland
left a comment
Member
There was a problem hiding this comment.
This looks good, but currently has a merge conflict.
Make sure that a write and read leave the stream in a non-error and EOF state.
Flamefire
force-pushed
the
stream-op
branch
from
September 13, 2026 16:28
a1d303f to
74d6d20
Compare
Contributor
Author
|
Rebased. CI passes again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users might want to test if reading or writing the RNG state worked
The only way is checking the stream state.
So add assertions for that and fix the offending ones