[Refactor] Generalize Fast conversation boundaries - #1452
Merged
Conversation
Contributor
This was referenced Aug 18, 2026
daniel-lxs
force-pushed
the
codex/generalize-fast-conversation-core
branch
from
August 18, 2026 19:14
7606ea5 to
96f49d6
Compare
daniel-lxs
marked this pull request as ready for review
August 18, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Fast already behaves as one conversational orchestrator across human messages and delegated-task updates, but its shared service boundary was still expressed in Slack-specific coordinates and callbacks. This refactor makes that boundary match the product model and gives later lifecycle-delivery work a clean provider-neutral core to build on.
This is intentionally behavior-preserving. The existing Slack-shaped persistence schema and Slack task-event parent remain behind adapters; generalizing lifecycle parent delivery is a separate follow-up.
Validation
pnpm --filter @roomote/cloud-agents check-typespnpm --filter @roomote/api check-typespnpm --filter @roomote/sdk check-types@roomote/cloud-agentsVitest suite@roomote/apiVitest suite (206 files, 1,786 tests)@roomote/sdkVitest suite (99 files, 995 tests)pnpm lint:fastpnpm check-types:fastpnpm knip