Skip to content

[Refactor] Generalize Fast conversation boundaries - #1452

Merged
daniel-lxs merged 1 commit into
developfrom
codex/generalize-fast-conversation-core
Aug 18, 2026
Merged

[Refactor] Generalize Fast conversation boundaries#1452
daniel-lxs merged 1 commit into
developfrom
codex/generalize-fast-conversation-core

Conversation

@daniel-lxs

Copy link
Copy Markdown
Member

What

  • introduce provider-neutral Fast conversation, reply, reaction, and turn-adapter types
  • make the Fast service, session lookup, turn locking, and integration broker consume one conversation identity
  • keep Slack and Discord delivery details in their surface adapters
  • preserve existing persisted and Redis identities through an explicit compatibility mapping

Why

Fast already behaves as one conversational orchestrator across human messages and delegated-task updates, but its shared service boundary was still expressed in Slack-specific coordinates and callbacks. This refactor makes that boundary match the product model and gives later lifecycle-delivery work a clean provider-neutral core to build on.

This is intentionally behavior-preserving. The existing Slack-shaped persistence schema and Slack task-event parent remain behind adapters; generalizing lifecycle parent delivery is a separate follow-up.

Validation

  • pnpm --filter @roomote/cloud-agents check-types
  • pnpm --filter @roomote/api check-types
  • pnpm --filter @roomote/sdk check-types
  • full @roomote/cloud-agents Vitest suite
  • full @roomote/api Vitest suite (206 files, 1,786 tests)
  • full @roomote/sdk Vitest suite (99 files, 995 tests)
  • pnpm lint:fast
  • pnpm check-types:fast
  • pnpm knip

@roomote-community

roomote-community Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 96f49d6

@daniel-lxs
daniel-lxs force-pushed the codex/generalize-fast-conversation-core branch from 7606ea5 to 96f49d6 Compare August 18, 2026 19:14
@daniel-lxs
daniel-lxs marked this pull request as ready for review August 18, 2026 19:14
@daniel-lxs
daniel-lxs merged commit d7d377d into develop Aug 18, 2026
16 checks passed
@daniel-lxs
daniel-lxs deleted the codex/generalize-fast-conversation-core branch August 18, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant