[Refactor] Generalize Fast parent event delivery - #1453
Merged
Conversation
Contributor
|
No code issues found. See task
Reviewed ac34c3b |
daniel-lxs
force-pushed
the
codex/generalize-fast-conversation-core
branch
from
August 18, 2026 19:14
7606ea5 to
96f49d6
Compare
daniel-lxs
force-pushed
the
codex/generalize-fast-parent-events
branch
from
August 18, 2026 19:14
a5637ef to
6a4591d
Compare
Base automatically changed from
codex/generalize-fast-conversation-core
to
develop
August 18, 2026 19:24
daniel-lxs
marked this pull request as ready for review
August 18, 2026 19:24
daniel-lxs
force-pushed
the
codex/generalize-fast-parent-events
branch
from
August 18, 2026 19:24
6a4591d to
ac34c3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FastAgentConversationandFastAgentParentshared, validated contracts in@roomote/typesslackPostedto the provider-neutralreplyPostedWhy
The Fast core can now treat Slack and Discord as adapters, but delegated tasks still persisted their parent as Slack coordinates and the lifecycle coordinator contained Slack delivery inline. This stacked refactor removes that coupling and leaves an explicit surface adapter seam for adding Discord lifecycle delivery without changing the orchestration loop again.
This is stacked on #1452. Discord parent stamping and delivery are intentionally the next follow-up; this PR makes that addition isolated instead of mixing it into the contract migration.
Validation
@roomote/types: 55 files, 849 tests@roomote/cloud-agents: 95 files, 769 tests@roomote/slack: 38 files, 402 tests@roomote/sdk: 99 files, 996 testspnpm lint:fastpnpm check-types:fastpnpm knipThe full Worker suite reached 1,747/1,748 tests; the unrelated
tail-file-path.test.tssymlink assertion failed outside this diff. The affected Worker suites pass.