Give installed Companion runtimes explicit ownership - #31
Merged
Pelotrio merged 1 commit intoSep 11, 2026
Merged
Conversation
Pelotrio
added this pull request to stack #30
September 11, 2026 14:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing or retiring a Companion runtime previously updated separate service/index fields and repeated consumer-close ordering. Installation also performed debugger/UI follow-up before the loader considered index ownership transferred, so a late failure could dispose an already-published index.
RuntimeBindingnow groups the installed inventory metadata, decompiler and reference search, detaches compiler/insight bindings before closing its native index, and distinguishes prepared candidates from accepted ownership. The JDT static index accessor is only a lookup hook. Fallible follow-up is queued before publication and runs afterward on the existing project worker, outside the lifecycle lock. Stateless parsing moves toJavaAst, separate from the editor AST cache.The application-lived compiler and code-insight services keep their identity, which existing local editors rely on. Project admission and navigation invalidation retain their existing guards; their scope/identity migration is in #32. No protocol changes, additional executor, or second index.
Validation:
:check :localBundle -PtotaldebugUseMavenLocal=true --offline --warning-mode failpassed. Regressions cover accepted/rejected ownership, idempotent close, failed preparation, and the actual application installation path with a failing debugger follow-up. No live Minecraft validation or installation.Stack: based on #29 (
codex/companion-disposal), following #28 and #27. This is the runtime-ownership slice of the architecture plan. The separate uncommitted selector/MCP follow-up is excluded.Review notes: the runtime follow-up (breakpoint restore, UI refresh, parser prewarm) moved from the loader's callback onto the project worker because the ready handler runs under the lifecycle lock and no debugger wait may run there; install timing changes accordingly. The plan's
NavigationService.runtimeGeneration→ binding identity item is deferred to #32, which lands it together with per-view runtime identity.