Dispose Companion UI resources with their owners - #29
Merged
Pelotrio merged 1 commit intoSep 11, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing project windows could retain runtime-status listeners and script popup windows, while some editor cleanup depended on a parent-removal event. This change gives each owner explicit disposal and prevents queued callbacks from updating disposed UI.
Search Everywhere unregisters its listener, script panels own their popups and original result-bus subscriptions, usage views cancel searches explicitly, and Code Vision releases its AST subscription without removing other editor listeners.
Validation:
:check :localBundle -PtotaldebugUseMavenLocal=true --offline --warning-mode failpassed, including disposal regressions and packaging checks. No live Minecraft validation or installation.Part of the native GitHub stack targeting
1.21.1: #27 → #28 → this PR → #31. This PR contains only the disposal slice from the architecture plan; #31 contains runtime ownership. Review each slice separately and merge dependencies from the bottom of the stack. The uncommitted project-selector/MCP follow-up is excluded.