TS Test Conversion

.eslintrc

@@ -193,7 +193,7 @@
   overrides: [
     {
       // Specific rules for test files
-      files: [ "packages/**/test/**/*-test.js" ],
+      files: [ "packages/**/test/**/*-test.ts" ],
       plugins: [ "eslint-plugin-promise" ],
       rules: {
         "import/no-extraneous-dependencies": "off",
@@ -203,7 +203,7 @@
     },
     {
       // TypeScript source files
-      files: [ "packages/**/*.ts" ],
+      files: [ "packages/**/*.ts", "test/**/*.ts" ],
       parser: "@typescript-eslint/parser",
       extends: [ "plugin:@typescript-eslint/recommended-requiring-type-checking" ],
       parserOptions: {

package.json

@@ -20,11 +20,11 @@
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-promise": "^7.3.0",
     "lerna": "^4.0.0",
+    "light-my-request": "^6.6.0",
     "manual-git-changelog": "^1.0.1",
     "node-gyp": "^11.0.0",
     "pre-commit": "^2.0.0",
     "rdf-object": "^1.14.0",
-    "supertest": "^7.0.0",
     "typescript": "^5.9.3",
     "vitest": "^4.1.10"
   },
@@ -37,14 +37,14 @@
     "lint-changed": "lerna run lint --since HEAD",
     "test": "vitest run --coverage",
     "test-ci": "vitest run --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit",
-    "build": "tsc -p tsconfig.json",
+    "typecheck": "tsc -p tsconfig.typecheck.json --noEmit",
+    "build": "tsc -p tsconfig.build.json",
     "lint": "eslint packages/*/bin/* packages/*/lib packages/*/test test --ext .js,.ts",
     "clean": "rm -rf ./node_modules && rm -rf ./packages/*/node_modules",
     "dedupe": "npx yarn-deduplicate yarn.lock --scopes",
     "publish": "lerna publish",
     "publish-bare": "lerna exec -- npm publish --silent",
-    "postinstall": "lerna run prepare && yarn run build",
+    "postinstall": "lerna run prepare && yarn run build && yarn run typecheck",
     "version": "manual-git-changelog onversion"
   }
 }

packages/core/lib/routers/DatasourceRouter.ts

@@ -2,10 +2,10 @@
 /* A DatasourceRouter routes URLs to data sources. */
 
 import { UrlData } from '../UrlData';
-import type { Query, RouterRequest } from '../types';
+import type { Query, Router, RouterRequest } from '../types';
 
 // Creates a new DatasourceRouter
-export class DatasourceRouter {
+export class DatasourceRouter implements Router {
   protected _baseLength: number;
 
   constructor(options?: { urlData?: UrlData }) {

packages/core/lib/routers/PageRouter.ts

@@ -1,10 +1,10 @@
 /*! @license MIT ©2014-2016 Ruben Verborgh, Ghent University - imec */
 /* A PageRouter routes page numbers to offsets */
 
-import type { Query, RouterRequest } from '../types';
+import type { Query, Router, RouterRequest } from '../types';
 
 // Creates a new PageRouter with the given page size, which defaults to 100.
-export class PageRouter {
+export class PageRouter implements Router {
   pageSize: number;
 
   constructor(config?: { pageSize?: number }) {

packages/core/lib/types.ts

@@ -93,10 +93,15 @@ export interface LdfResponse extends ServerResponse {
 // The (already-parsed) request shape routers' extractQueryParams receives —
 // note this is distinct from LdfRequest: callers pass { url: request.parsedUrl, headers }.
 export interface RouterRequest {
-  url?: { pathname?: string; query?: ParsedUrlQuery };
+  url?: { pathname?: string | null; query?: ParsedUrlQuery };
   headers?: IncomingHttpHeaders;
 }
 
+// A router extracts query parameters from a (partial) request into a query object
+export interface Router {
+  extractQueryParams(request: RouterRequest, query: Query): void;
+}
+
 // Options accepted by the Controller base class (and its subclasses) constructor
 export interface ControllerOptions {
   urlData?: UrlData;

packages/core/package.json

@@ -25,7 +25,7 @@
     "lint": "eslint bin/* lib test"
   },
   "dependencies": {
-    "asynciterator": "^3.0.0",
+    "asynciterator": "^3.10.0",
     "componentsjs": "^4.0.4",
     "forwarded-parse": "^2.1.0",
     "jsonld-streaming-serializer": "^3.0.0",