TS Test Conversion - #222
Open
Michiel-VandeVelde wants to merge 16 commits into
Open
Conversation
jitsedesmet
requested changes
Sep 3, 2026
jitsedesmet
left a comment
jitsedesmet
left a comment
There was a problem hiding this comment.
First round of comments/ opinions :)
…op InstanceType - Fold typecheck into postinstall, drop separate CI step (per review) - Migrate controller tests off real ports to light-my-request injection, keep listen() for LinkedDataFragmentsServer-test.ts (relies on response 'error' events as a recoverable signal, incompatible with light-my-request) - Make DummyServer a class exposing next/error directly, drop SpiedController/Partial workaround - Replace InstanceType<typeof X> & Partial<SpiedController> patterns with direct class imports across controller test files - Remove unused supertest/@types/supertest dependency
…ping, narrow HttpResponse
- Add Router interface to core/lib/types.ts, have DatasourceRouter, PageRouter
and QuadPatternRouter implement it explicitly instead of each router-consuming
file declaring its own local duck-typed interface
- Widen RouterRequest.url.pathname to string | null, matching Node's own
url.parse()/UrlObject convention, removing the need for callers to coerce
null to undefined
- Apply reviewer's suggested { url: parsed } simplification in test-helpers.ts,
now unblocked by the pathname widening above
- Make test-helpers.ts's HttpResponse extend IncomingMessage instead of
Readable, mirroring the existing StreamCapture/ServerResponse pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.