Analyse analytic and conversion functions with complete window traversal - #2579
Merged
manticore-projects merged 1 commit intoSep 11, 2026
Merged
Conversation
Contributor
|
Thank you very much for fixing this so fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFeatures(pureFunctions)misses the function name in an analytic call or CONVERT/TRY_CONVERT expression, so unproven calls can be classified as unable to modify data. Window PARTITION BY, ORDER BY and FILTER expressions are also skipped, and an aggregate's internal ORDER BY can trigger a null-list exception.Share function-name normalization and purity checks across the three expression forms. Use the conversion keyword as the function name, and preserve qualified analytic names through the existing Function name renderer. Unproven effects remain possible rather than certain.
WindowDefinition now supplies its partition, ordering and frame expressions to both inline and named-window traversal. ExpressionVisitorAdapter visits both ordering lists, filters and function modifiers through its existing child-visitor hook. Ordinary and analytic functions share modifier collection, preserving HAVING, keyword arguments and LIMIT expressions when a Function becomes an AnalyticExpression.
Validation: full Gradle
checkand Mavenverify; pure/unproven function controls, qualified names, nested calls, inline/named windows, both ordering lists, FILTER, frame bounds, offsets/defaults, modifier conversion, callback order/context and existing feature/visitor regression tests.Fixes #2575.