|
| 1 | +/*- |
| 2 | + * #%L |
| 3 | + * JSQLParser library |
| 4 | + * %% |
| 5 | + * Copyright (C) 2004 - 2026 JSQLParser |
| 6 | + * %% |
| 7 | + * Dual licensed under GNU LGPL 2.1 or Apache License 2.0 |
| 8 | + * #L% |
| 9 | + */ |
| 10 | +package net.sf.jsqlparser.expression; |
| 11 | + |
| 12 | +import static org.assertj.core.api.Assertions.assertThat; |
| 13 | + |
| 14 | +import java.util.ArrayList; |
| 15 | +import java.util.Collection; |
| 16 | +import java.util.List; |
| 17 | +import java.util.Set; |
| 18 | +import java.util.stream.Stream; |
| 19 | +import net.sf.jsqlparser.JSQLParserException; |
| 20 | +import net.sf.jsqlparser.parser.CCJSqlParserUtil; |
| 21 | +import net.sf.jsqlparser.statement.Statement; |
| 22 | +import net.sf.jsqlparser.statement.StatementFeatures; |
| 23 | +import net.sf.jsqlparser.statement.StmtFeature; |
| 24 | +import net.sf.jsqlparser.statement.select.Limit; |
| 25 | +import net.sf.jsqlparser.statement.select.PlainSelect; |
| 26 | +import net.sf.jsqlparser.statement.select.SelectItem; |
| 27 | +import net.sf.jsqlparser.statement.select.SelectVisitorAdapter; |
| 28 | +import org.junit.jupiter.api.Test; |
| 29 | +import org.junit.jupiter.params.ParameterizedTest; |
| 30 | +import org.junit.jupiter.params.provider.Arguments; |
| 31 | +import org.junit.jupiter.params.provider.MethodSource; |
| 32 | +import org.junit.jupiter.params.provider.ValueSource; |
| 33 | + |
| 34 | +class FunctionFeatureAnalysisTest { |
| 35 | + static Stream<Arguments> functionForms() { |
| 36 | + return Stream.of( |
| 37 | + Arguments.of("SELECT pg_sleep(1) FROM t", "pg_sleep"), |
| 38 | + Arguments.of("SELECT pg_sleep(1) OVER () FROM t", "pg_sleep"), |
| 39 | + Arguments.of("SELECT SuM(v) OVER () FROM t", "sum"), |
| 40 | + Arguments.of("SELECT analytics.sum(v) OVER () FROM t", "analytics.sum"), |
| 41 | + Arguments.of("SELECT CONVERT(v USING utf8) FROM t", "convert"), |
| 42 | + Arguments.of("SELECT CONVERT(INT, v) FROM t", "convert"), |
| 43 | + Arguments.of("SELECT TRY_CONVERT(INT, v) FROM t", "try_convert")); |
| 44 | + } |
| 45 | + |
| 46 | + @ParameterizedTest |
| 47 | + @MethodSource("functionForms") |
| 48 | + void appliesTheSamePurityContractToEachFunctionForm(String sql, String name) |
| 49 | + throws JSQLParserException { |
| 50 | + Statement statement = CCJSqlParserUtil.parse(sql); |
| 51 | + String before = statement.toString(); |
| 52 | + StatementFeatures unknown = statement.getFeatures(n -> false); |
| 53 | + assertThat(unknown.getUnresolvedReferences()).containsExactly(name); |
| 54 | + assertThat(unknown.getUncertain()) |
| 55 | + .contains(StmtFeature.MODIFIES_DATA, StmtFeature.MODIFIES_SCHEMA); |
| 56 | + assertThat(unknown.modifiesData()).isFalse(); |
| 57 | + assertThat(unknown.mayModifyData()).isTrue(); |
| 58 | + |
| 59 | + StatementFeatures pure = statement.getFeatures(name::equals); |
| 60 | + assertThat(pure.getUnresolvedReferences()).isEmpty(); |
| 61 | + assertThat(pure.mayModifyData()).isFalse(); |
| 62 | + assertThat(statement.toString()).isEqualTo(before); |
| 63 | + assertThat(CCJSqlParserUtil.parse(before).toString()).isEqualTo(before); |
| 64 | + } |
| 65 | + |
| 66 | + @ParameterizedTest |
| 67 | + @ValueSource(strings = { |
| 68 | + "SELECT sum(danger(v)) OVER () FROM t", |
| 69 | + "SELECT sum(v) OVER (PARTITION BY danger(k)) FROM t", |
| 70 | + "SELECT sum(v) OVER (ORDER BY danger(k)) FROM t", |
| 71 | + "SELECT sum(v) FILTER (WHERE danger(k) > 0) OVER () FROM t", |
| 72 | + "SELECT array_agg(v ORDER BY danger(k)) OVER () FROM t", |
| 73 | + "SELECT lag(v, danger(k), 0) OVER () FROM t", |
| 74 | + "SELECT lag(v, 1, danger(k)) OVER () FROM t", |
| 75 | + "SELECT sum(v) OVER (ORDER BY k ROWS danger(1) PRECEDING) FROM t", |
| 76 | + "SELECT sum(v) OVER (ORDER BY k ROWS BETWEEN danger(1) PRECEDING AND CURRENT ROW) FROM t", |
| 77 | + "SELECT sum(v) OVER (ORDER BY k ROWS BETWEEN CURRENT ROW AND danger(1) FOLLOWING) FROM t", |
| 78 | + "SELECT sum(v) OVER w FROM t WINDOW w AS (PARTITION BY danger(k))", |
| 79 | + "SELECT sum(v) OVER w FROM t WINDOW w AS (ORDER BY danger(k))", |
| 80 | + "SELECT sum(v) OVER w FROM t WINDOW w AS (ORDER BY k ROWS danger(1) PRECEDING)", |
| 81 | + "SELECT CONVERT(INT, danger(v)) FROM t"}) |
| 82 | + void pureOuterFunctionsDoNotHideUnprovenChildren(String sql) throws JSQLParserException { |
| 83 | + StatementFeatures features = CCJSqlParserUtil.parse(sql) |
| 84 | + .getFeatures(Set.of("sum", "array_agg", "lag", "convert")::contains); |
| 85 | + assertThat(features.getUnresolvedReferences()).containsExactly("danger"); |
| 86 | + assertThat(features.mayModifyData()).isTrue(); |
| 87 | + assertThat(features.modifiesData()).isFalse(); |
| 88 | + } |
| 89 | + |
| 90 | + @Test |
| 91 | + void inlineWindowVisitsBothOrderListsOnceAndKeepsContext() throws JSQLParserException { |
| 92 | + String sql = "SELECT array_agg(arg_fn(v) ORDER BY inner_fn(k)) " |
| 93 | + + "FILTER (WHERE filter_fn(v) > 0) OVER (PARTITION BY part_fn(k) " |
| 94 | + + "ORDER BY outer_fn(k) ROWS BETWEEN start_fn(1) PRECEDING " |
| 95 | + + "AND end_fn(1) FOLLOWING) FROM t"; |
| 96 | + PlainSelect select = (PlainSelect) CCJSqlParserUtil.parse(sql); |
| 97 | + List<String> seen = new ArrayList<>(); |
| 98 | + Object marker = new Object(); |
| 99 | + ExpressionVisitorAdapter<Void> expressions = new ExpressionVisitorAdapter<Void>() { |
| 100 | + @Override |
| 101 | + public <S> Void visit(Function function, S context) { |
| 102 | + assertThat(context).isSameAs(marker); |
| 103 | + seen.add(function.getName()); |
| 104 | + return super.visit(function, context); |
| 105 | + } |
| 106 | + |
| 107 | + @Override |
| 108 | + protected <S> Void visitExpressions(Expression expression, S context, |
| 109 | + Collection<Expression> children) { |
| 110 | + assertThat(context).isSameAs(marker); |
| 111 | + return super.visitExpressions(expression, context, children); |
| 112 | + } |
| 113 | + }; |
| 114 | + select.accept(new SelectVisitorAdapter<>(expressions), marker); |
| 115 | + assertThat(seen).containsExactly("arg_fn", "filter_fn", "inner_fn", "part_fn", |
| 116 | + "outer_fn", "start_fn", "end_fn"); |
| 117 | + } |
| 118 | + |
| 119 | + @Test |
| 120 | + void functionModifiersRemainVisibleAfterAnalyticConversion() { |
| 121 | + Function function = new Function().withName("parent").withParameters(new LongValue(1)); |
| 122 | + function.setHavingClause(new Function.HavingClause(Function.HavingClause.HavingType.MAX, |
| 123 | + new Function().withName("having_fn"))); |
| 124 | + function.setKeywordArguments(List.of(new Function.KeywordArgument("SEPARATOR", |
| 125 | + new Function().withName("keyword_fn")))); |
| 126 | + function.setLimit(new Limit().withRowCount(new Function().withName("limit_fn"))); |
| 127 | + for (Expression expression : List.of(function, new AnalyticExpression(function))) { |
| 128 | + PlainSelect select = new PlainSelect(); |
| 129 | + select.setSelectItems(List.of(new SelectItem<>(expression))); |
| 130 | + assertThat(select.getFeatures("parent"::equals).getUnresolvedReferences()) |
| 131 | + .containsExactly("having_fn", "keyword_fn", "limit_fn"); |
| 132 | + } |
| 133 | + } |
| 134 | + |
| 135 | + @Test |
| 136 | + void emptyAndUnboundedWindowsContainNoSpuriousFunctions() throws JSQLParserException { |
| 137 | + assertThat(new WindowDefinition().getAllExpressions()).isEmpty(); |
| 138 | + Statement statement = CCJSqlParserUtil.parse("SELECT sum(v) OVER " |
| 139 | + + "(ORDER BY k ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) FROM t"); |
| 140 | + assertThat(statement.getFeatures("sum"::equals).mayModifyData()).isFalse(); |
| 141 | + } |
| 142 | +} |
0 commit comments