Answer coordinator node descriptor requests during Zigbee 3.0 commissioning - #60
Open
danielstena wants to merge 3 commits into
Open
Answer coordinator node descriptor requests during Zigbee 3.0 commissioning#60danielstena wants to merge 3 commits into
danielstena wants to merge 3 commits into
Conversation
Contributor
|
Thanks! What device are you using that requires this change? |
Contributor
|
I noticed this PR has changed drastically since it was opened. Ziggurat expects the radio library to handle node descriptor requests, as in zigpy-ziggurat: https://github.com/zigpy/zigpy-ziggurat/blob/c92f7356f9cc2ace2d563578ab69b9e5270ae80b/zigpy_ziggurat/zigbee/application.py#L617 How are you running Ziggurat to require this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zigbee 3.0 end devices query the coordinator Node Descriptor before requesting a fresh Trust Center link key. Ziggurat previously forwarded Node_Desc_req to the client without answering it, so joining devices could time out key establishment and leave the network.
This change:
Hardware evidence:
Verification:
The two allowed Clippy lints are pre-existing under the current Rust toolchain.