Conversation
vjik
commented
Jul 7, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
=============================================
+ Coverage 99.02% 100.00% +0.97%
Complexity 37 37
=============================================
Files 7 7
Lines 103 103
=============================================
+ Hits 102 103 +1
+ Misses 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samdark
reviewed
Jul 7, 2026
| php: >- | ||
| ['8.2'] | ||
| test-extensions: :openssl | ||
| name: PHP 8.2 without openssl |
Member
There was a problem hiding this comment.
Can't we reuse action from yiisoft/actions?
Member
Author
There was a problem hiding this comment.
There's a specific edge case in this package. Adding this to yiisoft/actions is overhead. Seems, it's not needed anywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.