Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ios/Sources/GutenbergKit/Sources/EditorViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,13 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
// it because the WebView has no auth cookies). Without both there is nothing
// to upload through, so leave the server down and let uploads fall to the
// default WebView path rather than start a server that could only fail.
guard !configuration.authHeader.isEmpty else {
//
// `MediaServerCredentials` owns the check so it is reachable from the host
// test suite — this file is not.
guard MediaServerCredentials.areUsable(
siteApiRoot: configuration.siteApiRoot,
authHeader: configuration.authHeader
) else {
Comment on lines +474 to +477

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding from Claude:

This widens the gate from !authHeader.isEmpty to also require an addressable siteApiRoot — but a delegate that handles uploads itself never touches DefaultMediaUploader. MediaUploadServer.processAndUpload returns .uploaded(result) straight from uploadDelegate without resolving context.defaultUploader, so that host now loses its own upload path over a site root it never uses.

Intended? If not, the site-root arm belongs where defaultUploader is actually built.

return
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import Foundation

/// Whether the editor configuration can reach the configured site for media.
///
/// Deliberately outside `EditorViewController`. That type is `#if canImport(UIKit)`,
/// so on the macOS host it does not exist and nothing in it can be tested — including
/// this check, which already diverged silently between iOS and Android once. Living
/// here, it is reachable from the host test suite.
enum MediaServerCredentials {
/// Whether a ``DefaultMediaUploader`` built from this configuration could actually
/// reach the site.
///
/// Both fields are required. The uploader delivers GutenbergKit's uploads to the
/// configured site, so it needs somewhere to send them and credentials to be
/// accepted; with either missing, every media request it makes fails.
///
/// `siteApiRoot` is a `URL` here where Android types it as a `String`, so the
/// equivalent of Android's `isEmpty()` check is "not absolute" — a URL with no
/// scheme or host cannot address the site, and every request built from it fails at
/// the URLSession layer.
static func areUsable(siteApiRoot: URL, authHeader: String) -> Bool {
siteApiRoot.scheme != nil && siteApiRoot.host() != nil && !authHeader.isEmpty
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import Foundation
import Testing

@testable import GutenbergKit

@Suite("MediaServerCredentials")
struct MediaServerCredentialsTests {
private static let siteRoot = URL(string: "https://example.com/wp-json/")!

@Test("accepts an absolute site root with an auth header")
func acceptsUsableCredentials() {
#expect(MediaServerCredentials.areUsable(siteApiRoot: Self.siteRoot, authHeader: "Bearer t"))
}

@Test("rejects an empty auth header")
func rejectsEmptyAuthHeader() {
#expect(!MediaServerCredentials.areUsable(siteApiRoot: Self.siteRoot, authHeader: ""))
}

// The two arms below are what a `URL` makes different from Android's `String`:
// `isEmpty()` has no direct equivalent, so "addressable" is spelled as scheme and
// host both being present. A URL missing either cannot reach the site, and every
// request built from it fails at the URLSession layer.

@Test("rejects a site root with no scheme")
func rejectsSchemelessSiteRoot() {
let relative = URL(string: "example.com/wp-json/")!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding from Claude:

URL(string: "example.com/wp-json/") has no host either (scheme=nil, host=nil), so this passes on the host arm alone — and rejectsEmptySiteRoot already covers that shape. Nothing isolates scheme != nil; drop it from areUsable and all five tests stay green.

A network-path reference separates them (scheme=nil, host="example.com"):

Suggested change
let relative = URL(string: "example.com/wp-json/")!
let relative = URL(string: "//example.com/wp-json/")!

#expect(!MediaServerCredentials.areUsable(siteApiRoot: relative, authHeader: "Bearer t"))
}

@Test("rejects a site root with no host")
func rejectsHostlessSiteRoot() {
let fileURL = URL(fileURLWithPath: "/tmp/wp-json")
#expect(!MediaServerCredentials.areUsable(siteApiRoot: fileURL, authHeader: "Bearer t"))
}

@Test("rejects an empty site root, the default when a host configures none")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding from Claude:

siteApiRoot has no default — it's required on EditorConfiguration.init, on EditorConfigurationBuilder.init, and on Android's builder. A host can't configure none; "/" is a value someone passes deliberately.

Suggested change
@Test("rejects an empty site root, the default when a host configures none")
@Test("rejects a site root with no scheme or host")

func rejectsEmptySiteRoot() {
#expect(!MediaServerCredentials.areUsable(siteApiRoot: URL(string: "/")!, authHeader: "Bearer t"))
}
}
Loading