Note that ArduinoOTA is not in the release builds - #362
Conversation
ArduinoOTA is compiled in only when WLED_ENABLE_AOTA is defined, which no release build sets, and the settings UI hides the checkbox when it is not compiled in. The landing page advertised it as a feature and the settings page documented a row that release users never see.
|
Warning Review limit reached
Next review available in: 32 minutes Limit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@bharvey88 thanks, I'll need to think about how we should explain ArduinoOTA .... In fact we changed the default to "disabled" for security reasons in v16.0.0 - need to cross-check if its actually removed completely now 😅 |
ArduinoOTA is compiled in only when
WLED_ENABLE_AOTAis defined. That flag appears inwled.h,wled.cppandxml.cppbut is not set anywhere inplatformio.ini, so no release build has it, andaOtaEnableddefaults to false. The settings UI also hides the checkbox when it is not compiled in:https://github.com/wled/WLED/blob/main/wled00/xml.cpp#L671-L673
So the landing page advertised a feature the release binaries do not have, and the settings page documented a row those users never see.
basics/getting-started.mdlisted ArduinoOTA as an update method; that is removed in #360.