fix: handle middleware teardown in plugin mode

[bjohansebas]

…n compiler close

Summary

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

[changeset-bot]

⚠️ No Changeset found

Latest commit: 395b6cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

❌ Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.38%. Comparing base (c2d23a7) to head (395b6cd).

Files with missing lines	Patch %	Lines
lib/Server.js	94.54%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5703      +/-   ##
==========================================
+ Coverage   82.90%   89.38%   +6.47%     
==========================================
  Files          13       13              
  Lines        6126     6169      +43     
==========================================
+ Hits         5079     5514     +435     
+ Misses       1047      655     -392     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR fixes teardown behavior when webpack-dev-server is used in plugin mode (server.apply(compiler)), ensuring compiler.close() does not surface an error due to dev-middleware shutdown semantics in that mode.

Changes:

• Skip calling webpack-dev-middleware’s close() during Server.stop() when running in plugin mode (this.isPlugin).
• Add an e2e regression test that asserts compiler.close() completes without returning an error in plugin mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
test/e2e/api-plugin.test.js	Adds a regression test validating compiler.close() returns no error in plugin mode.
lib/Server.js	Avoids calling middleware.close() during teardown when Server is operating as a plugin (apply() mode).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.