Skip to content

chore: use plugin support#4791

Open
bjohansebas wants to merge 11 commits into
webpack:mainfrom
bjohansebas:dev-server-6
Open

chore: use plugin support#4791
bjohansebas wants to merge 11 commits into
webpack:mainfrom
bjohansebas:dev-server-6

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

Summary

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc8faa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.55556% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.46%. Comparing base (3cd7423) to head (bc8faa7).

Files with missing lines Patch % Lines
packages/webpack-cli/src/webpack-cli.ts 95.55% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4791      +/-   ##
==========================================
+ Coverage   93.43%   93.46%   +0.03%     
==========================================
  Files          14       14              
  Lines        5420     5513      +93     
  Branches      788      809      +21     
==========================================
+ Hits         5064     5153      +89     
- Misses        354      357       +3     
- Partials        2        3       +1     
Files with missing lines Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 96.92% <95.55%> (-0.04%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd7423...bc8faa7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas

Copy link
Copy Markdown
Member Author

I'm not sure if you want to support both dev-server 5 and 6 at the same time, with 6 being the one that has plugin support, or if you'd rather introduce this in a new major version for dev-server 6.

@bjohansebas bjohansebas left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's preferable to support dev-server 6 so it's easy to switch between versions, rather than releasing a new major version and making it more difficult to upgrade.

@bjohansebas bjohansebas marked this pull request as ready for review July 3, 2026 05:54
Copilot AI review requested due to automatic review settings July 3, 2026 05:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 3, 2026 06:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants