Test IO file sizes in Rust and array sizes in Python doctests - #9792
Test IO file sizes in Rust and array sizes in Python doctests#9792robert3005 wants to merge 2 commits into
Conversation
e1cf626 to
8bb4130
Compare
Merging this PR will improve performance by 25.6%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.4 µs | 13.3 µs | +53.75% |
| ⚡ | WallTime | words_gather_scalar_avx2[65536] |
9.4 µs | 8.2 µs | +13.59% |
| ⚡ | Simulation | allocate_drop_arrow[0] |
456.9 ns | 402.7 ns | +13.45% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/python-io-doctest-size (c0aae71) with develop (ad925fd)
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
8bb4130 to
d6147dd
Compare
joseph-isaacs
left a comment
There was a problem hiding this comment.
Can we move this into a rust test on the written file size. It really useful to know when we change file size
|
Here you go, there's a rust test now, I kept the python change since this is useful for docs |
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
e8208a8 to
c0aae71
Compare
Python io doc tests check compressed size in bytes since that's what they're talking about. Keep the file size test as a rust test