Skip to content

Replace all usages of Registry<T> with ArcSwapMap#8919

Open
robert3005 wants to merge 3 commits into
developfrom
rk/noregistyr
Open

Replace all usages of Registry<T> with ArcSwapMap#8919
robert3005 wants to merge 3 commits into
developfrom
rk/noregistyr

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

All our registries are read heavy but rarely require writes

@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1846 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compare_bool_nullable 41.1 µs 50.3 µs -18.39%
Simulation decompress[u8, (1000, 4)] 31.2 µs 23.4 µs +33.4%
Simulation encode_primitives[i64, (1000, 512)] 136.6 µs 116.9 µs +16.88%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/noregistyr (4a7a225) with develop (2f8c569)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 added the changelog/break A breaking API change label Jul 23, 2026
@robert3005
robert3005 requested a review from joseph-isaacs July 24, 2026 17:13
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant