Validate row-index selections#8574
Open
gatesn wants to merge 5 commits into
Open
Conversation
gatesn
marked this pull request as draft
June 24, 2026 15:06
Merging this PR will not alter performance
Comparing 
Footnotes
|
gatesn
marked this pull request as ready for review
June 24, 2026 15:17
gatesn
enabled auto-merge (squash)
June 24, 2026 15:28
robert3005
reviewed
Jun 24, 2026
Contributor
|
This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
Contributor
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
robert3005
force-pushed
the
ngates/selection-index-sortedness
branch
from
July 24, 2026 22:11
a2e44d2 to
b17f70b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rational for this change
We binary search the row selections and therefore panic if they are out of order. Therefore we should validate them on-construction to be sorted
What changes are included in this PR?
Include/ExcludeByIndex has try_new constructors.
An alternative would be to have a SortedBuffer wrapper type perhaps?
What APIs are changed? Are there any user-facing changes?
Include/ExcludeByIndex