Improve provenance

[mernst]

Merge #7941 first.

[coderabbitai]

Warning

Review limit reached

@mernst, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 27799086-ba6b-4e81-bd22-4dc110f9d98f

📥 Commits

Reviewing files that changed from the base of the PR and between a4d81bc and 2c1573c.

📒 Files selected for processing (1)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/Expression.java

📝 Walkthrough

Walkthrough

Type-inference constraints now retain derivation metadata and report typed parent history. Variable-bound incorporation uses provenance-aware helpers. A jtreg test verifies complementary-bound diagnostics. Nullness persistence tests migrate to java.lang.classfile and use ClassModel, typed annotation targets, and local position matching. Related tests require JDK 24 or later. Documentation now describes .goal diagnostic files.

Possibly related PRs

• typetools/checker-framework#7911: Both PRs modify VariableBounds.java bound handling.
• typetools/checker-framework#7918: Both PRs modify TypeConstraint and VariableBounds.
• typetools/checker-framework#7941: Both PRs include jtreg class-file API migrations.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 53.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@checker/jtreg/nullness/defaultsPersist/ReferenceInfoUtil.java`:
- Around line 110-112: Remove the System.out.println debug statement inside the
properName.equals(actualName) condition in ReferenceInfoUtil, leaving the
name-matching logic and existing ComparisonException reporting unchanged.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 57914c6e-5269-40b2-98f9-1e4a74f5277b

📥 Commits

Reviewing files that changed from the base of the PR and between 16f005f and ea36577.

📒 Files selected for processing (16)

• build.gradle
• checker/jtreg/nullness/PersistUtil.java
• checker/jtreg/nullness/defaultsPersist/Classes.java
• checker/jtreg/nullness/defaultsPersist/Constructors.java
• checker/jtreg/nullness/defaultsPersist/Driver.java
• checker/jtreg/nullness/defaultsPersist/Fields.java
• checker/jtreg/nullness/defaultsPersist/Methods.java
• checker/jtreg/nullness/defaultsPersist/ReferenceInfoUtil.java
• checker/jtreg/nullness/inheritDeclAnnoPersist/Driver.java
• checker/jtreg/nullness/inheritDeclAnnoPersist/Extends.java
• checker/jtreg/nullness/inheritDeclAnnoPersist/Implements.java
• checker/jtreg/nullness/inheritDeclAnnoPersist/ReferenceInfoUtil.java
• framework-test/src/main/java/org/checkerframework/framework/test/TestUtilities.java
• framework-test/src/main/java/org/checkerframework/framework/test/diagnostics/TestDiagnosticUtils.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/TypeConstraint.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/VariableBounds.java

[coderabbitai]

📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Remove the debug print.

Lines 110-112 print "For Anno: " + actualName for every name match, including matches in passing tests. The print adds noise to the jtreg output and provides no assertion value. The ComparisonException message at lines 133-141 already reports the failing annotation and position.

♻️ Proposed fix to drop the debug print

     for (TypeAnnotation anno : annotations) {
       String actualName = anno.annotation().className().stringValue();
-
-      if (properName.equals(actualName)) {
-        System.out.println("For Anno: " + actualName);
-      }
-
       if (properName.equals(actualName) && isAtPosition(expected, anno)) {
         return anno;
       }
     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@checker/jtreg/nullness/defaultsPersist/ReferenceInfoUtil.java` around lines
110 - 112, Remove the System.out.println debug statement inside the
properName.equals(actualName) condition in ReferenceInfoUtil, leaving the
name-matching logic and existing ComparisonException reporting unchanged.