Correct AGENTS.md fixture guidance#708
Merged
Merged
Conversation
why: Prevent contributors from requesting nonexistent window and pane fixtures or treating the doctest Server factory as the class. what: - Separate regular pytest fixtures from doctest namespace values - Show how tests derive windows and panes from the session fixture - Document the real Server import and socket-path lookup
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
- Coverage 51.86% 51.78% -0.09%
==========================================
Files 25 25
Lines 3638 3638
Branches 733 733
==========================================
- Hits 1887 1884 -3
- Misses 1445 1448 +3
Partials 306 306 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct contributor guidance so regular pytest tests use the
serverandsessionfixtures and derive windows and panes from a session.Document the actual doctest namespace, the
TestServerfactory bound toServer, the explicit import for the real class, and the socket-path lookup for named fixture servers.Verification
uv run ruff format --check .uv run ruff check .uv run mypy .uv run py.test --reruns 0 -q(1342 passed, 1 skipped)Closes #707