Conversation
Collaborator
Author
|
The above solution doesn't quite work; at least not in the TAS testing. I think you can trigger two NMI events on load and the logic I made assumes there will only be one. It should be fixable. |
Collaborator
Author
|
This version seems better. Passing the TAS tests and also cannot reproduce the lag frame when saving/loading in elevator room. For those wondering, the TAS was saving/loading in the middle of a short-charge with a single-frame tap to verify that the extra NMI cycles on save and load aren't messing with gameplay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs more testing. Also it needs to be communicated (I plan to make a post in the practice-hack discord channel in the next 24 hours; it's just getting late to do it tonight and I have a busy day tomorrow).
There is a scenario where even though costing a lag frame on save/load is "wrong", it's also been this way for a while; it's also not that wrong... I think this is the right change to make but there could be differing opinions on it. I'd also feel better after testing it more. My own testing on console shows improvement but I want to see it working in the BizHawk TAS as well (won't have time to test that until tomorrow).