Skip to content

refactor: delegate wallet state to Accounts SDK - #68

Draft
gakonst wants to merge 4 commits into
mainfrom
refactor/accounts-store-owner
Draft

refactor: delegate wallet state to Accounts SDK#68
gakonst wants to merge 4 commits into
mainfrom
refactor/accounts-store-owner

Conversation

@gakonst

@gakonst gakonst commented Jul 25, 2026

Copy link
Copy Markdown

Summary

  • delegate canonical ~/.tempo/wallet/store.json state to the Accounts SDK CLI provider and filesystem storage
  • consume the transactional Accounts store implementation from tempoxyz/accounts#747, temporarily pinned to immutable preview revision 1d58599
  • preserve wallet-cli ownership only for one-time legacy keys.toml migration
  • externalize Koffi from the esbuild bundle so @yao-pkg/pkg can package its native addon
  • install the Linux/macOS x64/arm64 Koffi artifacts used by the release matrix

Temporary dependency

The Accounts SDK dependency points to:

https://pkg.pr.new/tempoxyz/accounts@1d58599

Replace this preview pin with the released Accounts SDK version after #747 is merged and published.

Validation

  • pnpm check:types
  • pnpm test:types
  • pnpm test (116 tests)
  • pnpm check:lint
  • pnpm check:format
  • pnpm changelog:validate
  • pnpm package
  • packaged tempo-wallet logout smoke test using an isolated home directory; verified creation of both store.json and store.json.lock

Co-Authored-By: grandizzy 38490174+grandizzy@users.noreply.github.com

Prompted by: George

gakonst and others added 2 commits July 24, 2026 19:03
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43
@grandizzy
grandizzy force-pushed the refactor/accounts-store-owner branch from 772df5c to e0ee068 Compare August 3, 2026 07:47
@grandizzy grandizzy self-assigned this Aug 3, 2026
@grandizzy
grandizzy marked this pull request as draft August 3, 2026 07:47
Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43
Co-authored-by: Amp <amp@ampcode.com>
@socket-security

socket-security Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedkoffi@​3.1.2911008496100

View full report

Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fb66c-1cab-748e-95c4-a70fdf739f43
Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants