chore: fix flake in test_custom_slot_supplier_blocking#475
Merged
chris-olszewski merged 1 commit intoJul 5, 2026
Merged
Conversation
cconstable
approved these changes
Jul 2, 2026
chris-olszewski
force-pushed
the
olszewski/chore_assert_eventually_slot_supplier_test
branch
from
0a36eed to
0e9fc82
Compare
chris-olszewski
force-pushed
the
olszewski/chore_assert_eventually_slot_supplier_test
branch
from
0e9fc82 to
cea0210
Compare
chris-olszewski
deleted the
olszewski/chore_assert_eventually_slot_supplier_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Wrap the assertion that we receive a cancel for each waiting context in an
assert_eventuallyblock. Thecanceled_contextsare populated by a cancellation callbacks that are not necessarily completed before worker exit.Why?
Saw this flake in CI
Checklist
Closes N/A
How was this tested:
CI
Any docs updates needed?
N/A