Skip to content

fix flakey WorkflowUpdateTest.duplicateRejectedUpdate logic where ADMITTED was reported for updates that were actually COMPLETED. #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cconstable merged 2 commits into from
Jul 6, 2026
Merged

fix flakey WorkflowUpdateTest.duplicateRejectedUpdate logic where ADMITTED was reported for updates that were actually COMPLETED. #2940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b5e69
fix flakey WorkflowUpdateTest.duplicateRejectedUpdate logic where ADM…
cconstable Jul 3, 2026
873ba8b
fix rouge comment formatting
cconstable Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...t-server/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3172,13 +3172,16 @@ public UpdateWorkflowExecutionLifecycleStage waitForStage(
}

public UpdateWorkflowExecutionLifecycleStage getStage() {
if (!accepted.isDone()) {
return UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ADMITTED;
} else if (!outcome.isDone()) {
// A resolved outcome is terminal (a success result or a rejection/failure), so it always

@mjameswh mjameswh Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment formatting is weird

// means COMPLETED. Checking it first keeps stage derivation independent of the order in
// which the `accepted` and `outcome` futures complete. The `accepted` future only
// distinguishes ADMITTED from ACCEPTED.
if (outcome.isDone()) {
return UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_COMPLETED;
} else if (accepted.isDone()) {
return UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ACCEPTED;
}
return UpdateWorkflowExecutionLifecycleStage
.UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_COMPLETED;
return UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ADMITTED;
}

public String getId() {
Expand Down
Loading