fix: allow terminal profile deletion

app/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt

@@ -267,17 +267,7 @@ class EditProfileViewModel @Inject constructor(
                 isSaving = true,
             )
         }
-        val cleanupResult = privatePaykitRepo.removePublishedEndpointsForCleanup(TAG)
-        if (cleanupResult.isFailure) {
-            _uiState.update {
-                it.copy(
-                    isSaving = false,
-                    showDeleteFailureDialog = true,
-                )
-            }
-            return
-        }
-
+        privatePaykitRepo.removePublishedEndpointsForCleanup(TAG)
         val result = pubkyRepo.deleteProfileWithSessionRetry()
         if (result.isSuccess) {
             privatePaykitRepo.closeAndClear()

app/src/main/res/values/strings.xml

@@ -586,7 +586,7 @@
     <string name="profile__create_nav_title">Create Profile</string>
     <string name="profile__create_restoring">Restoring your existing profile…</string>
     <string name="profile__create_success">Profile created successfully</string>
-    <string name="profile__delete_confirm_description">Are you sure you want to delete all of your profile information for your pubky?</string>
+    <string name="profile__delete_confirm_description">Deleting your profile removes it from Pubky. Contacts may still retain profile and payment information previously shared with them.</string>
     <string name="profile__delete_confirm_title">Delete Profile?</string>
     <string name="profile__delete_error_description">We couldn\'t delete your profile data. Retry, or disconnect this pubky from Bitkit.</string>
     <string name="profile__delete_error_title">Unable to Delete Profile</string>

app/src/test/java/to/bitkit/ui/screens/profile/EditProfileViewModelTest.kt

@@ -159,20 +159,26 @@ class EditProfileViewModelTest : BaseUnitTest() {
     }
 
     @Test
-    fun `deleteProfile should stop when private cleanup fails`() = test {
+    fun `deleteProfile should continue when private cleanup fails`() = test {
         val sut = createSut()
         whenever { privatePaykitRepo.removePublishedEndpointsForCleanup(any()) }
             .thenReturn(Result.failure(TestAppError("cleanup failed")))
         whenever(pubkyRepo.deleteProfileWithSessionRetry()).thenReturn(Result.success(Unit))
         advanceUntilIdle()
 
-        sut.deleteProfile()
-        advanceUntilIdle()
+        sut.effects.test {
+            sut.deleteProfile()
+            advanceUntilIdle()
 
-        assertTrue(sut.uiState.value.showDeleteFailureDialog)
+            assertEquals(EditProfileEffect.DeleteSuccess, awaitItem())
+        }
+        assertFalse(sut.uiState.value.showDeleteFailureDialog)
         assertFalse(sut.uiState.value.isSaving)
-        verify(pubkyRepo, never()).deleteProfileWithSessionRetry()
-        verify(privatePaykitRepo, never()).closeAndClear()
+        inOrder(privatePaykitRepo, pubkyRepo).apply {
+            verify(privatePaykitRepo).removePublishedEndpointsForCleanup(any())
+            verify(pubkyRepo).deleteProfileWithSessionRetry()
+            verify(privatePaykitRepo).closeAndClear()
+        }
     }
 
     @Test

changelog.d/next/1108.fixed.md

@@ -0,0 +1 @@
+Fixed profile deletion being blocked when private Paykit contact cleanup could not complete.