Add as to cast wrapped protocols to a concrete type#819
Merged
Conversation
ktoso
reviewed
Jul 9, 2026
…/swift/ReturnProtocolCastTest.java
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
| ```java | ||
| <T extends JNISwiftInstance> Optional<T> as(Class<T> type, SwiftArena arena); | ||
| <T extends JNISwiftInstance> Optional<T> as(Class<T> type); // uses the default arena | ||
| ``` |
Collaborator
There was a problem hiding this comment.
I'd prefer to not have signatures copy pasted into docs
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
| // so we use Java reflection to call the static native downcall instead. | ||
| // and also the "constructor" to get back the correct Java wrapper. | ||
| Method metadata = type.getDeclaredMethod("$typeMetadataAddressDowncall"); | ||
| metadata.setAccessible(true); |
Collaborator
There was a problem hiding this comment.
We'll get warnings about this AFAIR on newer JDKs unless I'm misremembering, but that's fine for the time being... Better would be to just make the method public and avoid the setAccessible
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
ktoso
reviewed
Jul 9, 2026
Collaborator
|
LGTM, just needed to calm down Claude's over-explaining in docs a bit... Please try to trim it down in the docs some more next time 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
asmethod to wrappedinterfaces, such that we can recover the concrete type again.Tests and documentation were generated by Claude, but I validated it.