fix(build): unblock Release on bun 1.4.0 (cjs splitting + setup-repo bun pin) - #139
Merged
Conversation
…ss, pin setup-repo bun bun 1.4.0 (now "latest") hard-errors on splitting with non-esm formats, which older bun silently ignored; the Release workflow broke because tools/github/setup-repo installs bun-version latest while ci.yml pins 1.3.13. Disable splitting for the cjs build pass and pin setup-repo to the same 1.3.13 as ci.yml/packageManager. Verified bun run build green under both 1.3.13 and 1.4.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The develop Release run (32512875438) failed in
bun build:ci: bun 1.4.0 (currentlatest) hard-errors with "Code splitting is currently only supported when format is set to "esm"" — older bun silently ignoredsplitting: trueon the cjs pass. It hit the Release workflow (and not CI) becausetools/github/setup-repoinstallsbun-version: latest, whileci.ymlpins 1.3.13.tools/builder/index.ts: run the cjs pass withsplitting: false(esm pass unchanged)tools/github/setup-repo/action.yml: pinbun-version: 1.3.13, same as ci.yml /packageManagerVerified
bun run buildgreen under both 1.3.13 and 1.4.0.Note for later:
buildPackage's success check is!(buildESM.success || buildCJS.success)— a cjs-only failure is silently ignored when esm passes; left untouched here to stay minimal.🤖 Generated with Claude Code