fix(openai-sdk-python): isolate middleware clients - #1503
Open
abhinav7x94 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_supermemoryfrom mutating the supplied OpenAI clientAsyncOpenAImethods through async memory lookup and persistenceWhy
with_supermemoryreplacedclient.chat.completions.createin place. Reusing one OpenAI client with different middleware options stacked the wrappers, so one request could retrieve and inject memories from multiple tenants and persist a conversation through multiple tenant configurations.The wrapper now delegates unchanged SDK resources to the pristine client while overriding only memory-aware completion entry points. The caller's base client remains untouched.
OpenAI's decorated async
createmethods are not always reported as coroutine functions, and streaming variants intentionally return async context managers synchronously. The follow-up classifies the canonical client correctly and defers async middleware until streaming context entry, preventing skipped writes and unawaited-coroutine warnings.Validation
git diff --check