Conversation
`include` listed "experiments", which resolves relative to apps/framework and matches nothing, so experiments/ has never been typechecked. Point it at the repo root and exclude test files, which carry their own vitest types. Turning it on surfaces TS5097 on the twelve experiment files importing '../presets.ts' with a .ts extension; switch them to the '.js' specifier used everywhere else in the repo. tsx resolves it back to presets.ts at runtime, so experiment loading is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Sep 22, 2026
Rodriguespn
force-pushed
the
Rodriguespn/pr308-nested-experiments-proposal
branch
from
September 22, 2026 11:51
a2edffd to
1e930b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #315 rather than
main, so that PR can land already-correct. Found this while wiring up #324 / #325 — carrying the fix here so it isn't anyone else's problem.The bug
apps/framework/tsconfig.jsonhas"include": ["experiments", ...]. That path resolves relative toapps/framework, where noexperimentsdirectory exists, so it silently matches nothing:experiments/has never been typechecked, onmainor anywhere else. Pointing it at../../experimentsfixes it. Test files are excluded, since they carry their own vitest types that the framework's tsconfig doesn't pull in.Why it touches your twelve files
Turning the include on immediately surfaces
TS5097on all twelve experiment files:They import
'../presets.ts', and those are the only.tsimport specifiers in the repo — everything else ('./cli-channel.js','./docker-sandbox.js', …) uses the.jsform that TypeScript's module resolution expects. So this switches them to'../presets.js', one character each.Nothing changes at runtime:
tsxresolves the.jsspecifier back topresets.ts. I verified that rather than assuming it — all twelve experiments still load throughdiscoverExperimentFileswith their preset spreads applied:Why not land it separately on
mainOnly
format:checkgates PRs here —typecheckisn't in CI. So if the include fix landed on its own,mainwould pick up a silently brokenpnpm typecheckthe moment #315 merged, which is exactly how this got broken in the first place. Keeping both halves in one commit means the tree is green at every point.Verification
pnpm typecheckandpnpm format:checkboth clean on top of #315.