-
Notifications
You must be signed in to change notification settings - Fork 990
[WIP] Pressure Based Solver #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thijsaalbers
wants to merge
28
commits into
develop
Choose a base branch
from
feature_pressure_based_2026
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
64d4213
Initial configuration options and a test case
thijsaalbers 1a7e82a
Numerics and driver additions, WIP
thijsaalbers 8d0bcf9
Remove outdated numerics
thijsaalbers d973f19
Introduce pressure-based solver architecture in minimal form
thijsaalbers a1805d4
Add numerics
thijsaalbers d28be3b
Add variables and output
thijsaalbers 0b7f37b
MPI quantities
thijsaalbers e542979
Added momentum equations
thijsaalbers ef875fb
First working version of pressure correction
thijsaalbers 1931fa9
Added PISO and linear solver options
thijsaalbers 81f47a3
Altered some config parameters
thijsaalbers 30933b8
Removed duplicate code in iteration
thijsaalbers 425c39d
Small fix for poisson preconditioners
thijsaalbers 51827d8
Small cleanup on numerics
thijsaalbers c43dbba
forgotten meson file
thijsaalbers c7aadfa
Workaround for symmetry BC
thijsaalbers e2ec0e2
Latest working version of the solver
thijsaalbers d588424
small change
thijsaalbers 9207743
Merge branch 'develop' into feature_pressure_based_2026
thijsaalbers 9ca3e00
Fixed loading of restart file
thijsaalbers e421e68
Clean up of old code and commenting
thijsaalbers 1531084
updated test case
thijsaalbers 4df1bd7
Merge branch 'develop' into feature_pressure_based_2026
thijsaalbers 57639fd
fix for new linalg logic
thijsaalbers a8d8a8d
fix compile issue with OMP
thijsaalbers 5ed114c
fixed compile issue with OMP
thijsaalbers f3536fd
Small cleanup and testcases
thijsaalbers a992388
fixed tests
thijsaalbers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this variable still be named RCfactor? This factor is named RC to remain consistent with the thesis of Akshay, it however has no relation to Rhie-Chow at all and instead functions as a means of controlling the time dependent term on the momentum coefficients for the poisson equation... I do not know why he called it RC in his thesis, nor if we should keep this same name or change it.