Add standalone A/V lifecycle regression tests - #1774
Merged
Conversation
aleksandr-voitenko
changed the title
summeroff
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The tests directly cover the reported lifecycle regressions with bounded cleanup and no unresolved issues were found.
Pull request overview
Adds regression coverage for standalone audio/video encoder lifecycle behavior and adopts the corresponding libobs fix.
Changes:
- Adds synthetic A/V packet delivery and repeated cleanup tests.
- Verifies outputs cannot start after canvas removal.
- Updates libobs to
32.1.1sl9.
File summaries
| File | Description |
|---|---|
obs-studio-server/tests/test-osn-video-mix-lifecycle.cpp |
Adds standalone A/V lifecycle regression tests. |
.github/workflows/main.yml |
Updates the CI libobs version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add regression coverage for the encoder-pairing issue that prevented Auto Optimizer bandwidth probes from producing audio/video packets.
Motivation and Context
The runtime fix lives in
obs-studio. This PR updates libobs to32.1.1sl9and adds tests verifying:Tests use synthetic inputs and test encoders without network connections. No OSN runtime or public API changes.
Note: in the unavoidably bright future we must have tests like these directly inside OBS.
How Has This Been Tested?
Via tests run
Types of changes