build(workflows): remove stale Node.js version matrix includes in macos_test_npm_install#13232
Draft
Planeshifter wants to merge 1 commit into
Draft
build(workflows): remove stale Node.js version matrix includes in macos_test_npm_install#13232Planeshifter wants to merge 1 commit into
macos_test_npm_install#13232Planeshifter wants to merge 1 commit into
Conversation
…cos_test_npm_install`
The `test_npm_install` job in `macos_test_npm_install.yml` failed on
every nightly run on develop for 30+ consecutive days, with the
workflow reporting an overall failure while zero test jobs actually
ran (only the unrelated Zulip notification job executed).
Root cause: `NODE_VERSION` is `['20', '18', '16']`, but the `include`
list still listed entries for Node.js 14, 12, 10, 8, 6, 4, 0.12, and
0.10. Since those versions no longer match any base matrix
combination, GitHub Actions adds each as a standalone job
configuration missing `OS` and `BUILD_TASK`, which breaks
`runs-on: ${{ matrix.OS }}` and invalidates the entire job's matrix
expansion. This commit comments out the stale include entries,
matching the pattern already used in the sibling `linux_test.yml`
and `macos_test.yml` workflows.
Ref: https://github.com/stdlib-js/stdlib/actions/runs/28581700913
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
includeentries from thetest_npm_installjob's build matrix inmacos_test_npm_install.yml.Failing run: https://github.com/stdlib-js/stdlib/actions/runs/28581700913
Symptom:
macos_test_npm_installhas failed on every nightlydeveloprun for 30+ consecutive days. The run reports overallconclusion: failure, but zerotest_npm_installjobs actually run — only the unrelatedZulip notificationjob executes. Identical failure signature tolinux_test_install(see #13231).Root cause:
NODE_VERSIONis['20', '18', '16'], butincludestill lists entries for14,12,10,8,6,4,0.12,0.10. None of those values match any base matrix combination, so GitHub Actions adds each as a standalone job configuration containing only the keys given in theincludeentry — missingOSandBUILD_TASK.runs-on: ${{ matrix.OS }}then resolves to an empty string, invalidating the job's entire matrix expansion, so notest_npm_installjobs run and the workflow reports failure.Fix: comment out the eight stale
includeentries, identical to the pattern already in use in the siblinglinux_test.ymlandmacos_test.ymlworkflows.Related Issues
This pull request has no related issues.
Questions
No.
Other
Validation: YAML syntax checked with
python3 -c "import yaml; yaml.safe_load(...)". Three independent agent reviews (correctness, regression scope, style) all approved with no blocking findings.Reviewer notes: style reviewer noted
macos_test.ymladditionally carries a prose# Note: ...line explaining its reduced Node.js version list; this PR followslinux_test_install.yml's leaner inline-comment style instead. Non-blocking.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This pull request was prepared by Claude Code as part of an automated CI-failure investigation routine. Root cause was identified from job logs and GitHub Actions matrix semantics, cross-checked against the identical pattern already applied in sibling workflow files, and validated by three independent agent reviews.
@stdlib-js/reviewers
Generated by Claude Code