[6.x] Fix fieldtype picker showing the wrong list after switching blueprint types#14934
Closed
mynetx wants to merge 1 commit into
Closed
[6.x] Fix fieldtype picker showing the wrong list after switching blueprint types#14934mynetx wants to merge 1 commit into
mynetx wants to merge 1 commit into
Conversation
… types The picker caches its fieldtype list in a module-level ref shared across the whole CP session, but the cache wasn't keyed on blueprint mode. Form and regular blueprints load different lists (forms request `?forms=true`), so whichever picker opened first stuck until a full page reload. Key the cache by mode so each mode fetches and reuses its own list.
Member
|
This has already been fixed and merged. See #14919. BTW: Thanks for all these PRs, much appreciated! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fieldtype picker caches its list in a module-level ref that isn't keyed on whether you're in a form blueprint. Since the CP is an SPA, whichever picker you open first sticks — navigate from a regular blueprint to a form blueprint (or the other way around) and you get the wrong list until a full page reload.
This keys the cache by mode so each mode fetches and reuses its own list.
Fixes #14903