fix(operator): warn when VirtualMCPServer inline telemetry is ignored - #6408
fix(operator): warn when VirtualMCPServer inline telemetry is ignored#6408RaviTharuma wants to merge 1 commit into
Conversation
Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6408 +/- ##
==========================================
+ Coverage 77.69% 77.74% +0.05%
==========================================
Files 752 756 +4
Lines 72717 72799 +82
==========================================
+ Hits 56500 56601 +101
+ Misses 16212 16193 -19
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| usesIgnoredInline := vmcp.Spec.Config.Telemetry != nil && vmcp.Spec.TelemetryConfigRef == nil | ||
| r.emitInlineTelemetryIgnoredEvent(vmcp, usesIgnoredInline) |
There was a problem hiding this comment.
nit: this is passing both vmcp and a boolean calculated on its fields. Is there a reason why vmcp.Spec.Config.Telemetry and vmcp.Spec.TelemetryConfigRef are evaluated outside? If not, would you mind reducing this to func emitInlineTelemetryIgnoredEvent(vmcp *mcpv1beta1.VirtualMCPServer) and do al the math in it?
Follow-up from #6276 after closing #6277. Operator ignores spec.config.telemetry and emits a one-shot Warning (InlineTelemetryIgnored) when it is set without telemetryConfigRef. Docs no longer claim inline still works for operator vMCP. /metrics stays unregistered without the ref (HTTP 406).