Skip to content

fix(operator): warn when VirtualMCPServer inline telemetry is ignored - #6408

Open
RaviTharuma wants to merge 1 commit into
stacklok:mainfrom
RaviTharuma:fix/vmcp-inline-telemetry-warning
Open

fix(operator): warn when VirtualMCPServer inline telemetry is ignored#6408
RaviTharuma wants to merge 1 commit into
stacklok:mainfrom
RaviTharuma:fix/vmcp-inline-telemetry-warning

Conversation

@RaviTharuma

Copy link
Copy Markdown
Contributor

Follow-up from #6276 after closing #6277. Operator ignores spec.config.telemetry and emits a one-shot Warning (InlineTelemetryIgnored) when it is set without telemetryConfigRef. Docs no longer claim inline still works for operator vMCP. /metrics stays unregistered without the ref (HTTP 406).

Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.74%. Comparing base (b48013e) to head (43c6b0a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...perator/controllers/virtualmcpserver_controller.go 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6408      +/-   ##
==========================================
+ Coverage   77.69%   77.74%   +0.05%     
==========================================
  Files         752      756       +4     
  Lines       72717    72799      +82     
==========================================
+ Hits        56500    56601     +101     
+ Misses      16212    16193      -19     
  Partials        5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +50 to +51
usesIgnoredInline := vmcp.Spec.Config.Telemetry != nil && vmcp.Spec.TelemetryConfigRef == nil
r.emitInlineTelemetryIgnoredEvent(vmcp, usesIgnoredInline)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is passing both vmcp and a boolean calculated on its fields. Is there a reason why vmcp.Spec.Config.Telemetry and vmcp.Spec.TelemetryConfigRef are evaluated outside? If not, would you mind reducing this to func emitInlineTelemetryIgnoredEvent(vmcp *mcpv1beta1.VirtualMCPServer) and do al the math in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants