Skip to content

feat(ske): add ephemeral ske kubeconfig - #1448

Open
h3adex wants to merge 3 commits into
stackitcloud:mainfrom
h3adex:feat/add-ephemeral-resource-ske-kubeconfig
Open

feat(ske): add ephemeral ske kubeconfig#1448
h3adex wants to merge 3 commits into
stackitcloud:mainfrom
h3adex:feat/add-ephemeral-resource-ske-kubeconfig

Conversation

@h3adex

@h3adex h3adex commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the stackit_ske_kubeconfig ephemeral resource. The default expiration has been reduced to 30 minutes. Since these credentials only need to persist for the duration of a Terraform run, where even slow Helm deployments rarely exceed a 10-15 minute window, a 60-minute expiration is excessive.

Tested example code:
https://professional-service.git.onstackit.cloud/professional-service-best-practices/professional-service/pulls/18

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex
h3adex requested a review from a team as a code owner May 8, 2026 08:22
@h3adex
h3adex marked this pull request as draft May 8, 2026 08:23
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 2 times, most recently from e7a7211 to 21ffd96 Compare May 8, 2026 08:25
@h3adex h3adex mentioned this pull request May 8, 2026
Open
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 21ffd96 to 42e7091 Compare May 8, 2026 08:51
@h3adex

h3adex commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

don't review yet. E2E tests still open

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 9 times, most recently from 638204f to ad810c1 Compare May 11, 2026 11:24
@h3adex
h3adex marked this pull request as ready for review May 11, 2026 11:24
@h3adex

h3adex commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

E2E Tests
Screenshot 2026-05-11 at 14 00 48

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 3 times, most recently from cd6a220 to 0d06641 Compare May 18, 2026 06:23
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 0d06641 to 72e2165 Compare May 21, 2026 09:18
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label May 29, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 72e2165 to 23b550f Compare May 29, 2026 09:21
@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label May 30, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 2 times, most recently from dd0520a to 08623d4 Compare June 5, 2026 11:47
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 08623d4 to 096316e Compare June 9, 2026 11:23
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 096316e to 7e5049b Compare June 16, 2026 12:19
rubenhoenle
rubenhoenle requested changes Jun 23, 2026
View reviewed changes
Comment thread stackit/internal/services/ske/kubeconfig/ephemeral_resource.go Outdated
Comment thread stackit/internal/services/ske/kubeconfig/ephemeral_resource.go Outdated
Comment thread stackit/internal/services/ske/kubeconfig/ephemeral_resource.go Outdated
Comment thread stackit/internal/services/ske/kubeconfig/ephemeral_resource.go Outdated
Comment thread stackit/internal/services/ske/kubeconfig/ephemeral_resource_test.go Outdated
Comment thread stackit/internal/services/ske/testdata/resource-max.tf
Comment thread stackit/internal/services/ske/testdata/resource-min.tf
Comment thread examples/ephemeral-resources/stackit_ske_kubeconfig/ephemeral-resource.tf
@rubenhoenle rubenhoenle added the needs-work PR needs changes by the author. label Jun 24, 2026
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 2 times, most recently from 657b307 to 00866b7 Compare July 3, 2026 07:49
@rubenhoenle

rubenhoenle commented Jul 7, 2026

Copy link
Copy Markdown
Member

@h3adex please mark my conversations you adressed with your latest changes as resolved so this PR doesn't become a mess of open comments. Thanks.

@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 00866b7 to 7120e8b Compare July 8, 2026 07:32
@h3adex

h3adex commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@rubenhoenle only rebased. I'll try to update this PR this month. Currently busy covering multiple topics. Will update you once I covered your comments.

@h3adex
h3adex requested a review from rubenhoenle July 9, 2026 11:23
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from 98eace1 to 6ee1d50 Compare July 9, 2026 11:28
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jul 16, 2026
h3adex added 2 commits July 20, 2026 12:12
@h3adex
feat(ske): add ephemeral ske kubeconfig
dc5a5e8 
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
@h3adex
review changes
646921b 
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch 2 times, most recently from c9b5c88 to ea3a892 Compare July 20, 2026 10:16
@h3adex
add experimental status
cb934f4 
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
@h3adex
h3adex force-pushed the feat/add-ephemeral-resource-ske-kubeconfig branch from ea3a892 to cb934f4 Compare July 20, 2026 10:56
@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jul 29, 2026
@rubenhoenle

rubenhoenle commented Jul 29, 2026

Copy link
Copy Markdown
Member

@h3adex Please resolve the comments you've already adressed 😅

@github-actions github-actions Bot removed the Stale PR is marked as stale due to inactivity. label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle Awaiting requested review from rubenhoenle

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

needs-work PR needs changes by the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@h3adex @rubenhoenle @GokceGK