Skip to content

fix: drop pvc claims if not needed anymore - #743

Merged
Maleware merged 4 commits into
mainfrom
fix/drop-pvc-if-not-existing-anymore
Aug 21, 2026
Merged

fix: drop pvc claims if not needed anymore#743
Maleware merged 4 commits into
mainfrom
fix/drop-pvc-if-not-existing-anymore

Conversation

@Maleware

@Maleware Maleware commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

Hint: Code was written with the help of Claude.

Resolution of #722.

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@Maleware

Copy link
Copy Markdown
Member Author
=== NAME  kuttl
    harness.go:430: run tests finished
    harness.go:547: cleaning up
    harness.go:604: removing temp folder: ""
--- PASS: kuttl (270.35s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/tls-truststore_openshift-false_truststore-target-kind-ConfigMap (8.95s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-2048_custom-secret-names-True (43.46s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-2048_custom-secret-names-False (17.86s)
        --- PASS: kuttl/harness/non-sensitive-data (118.58s)
        --- PASS: kuttl/harness/cert-manager-tls_openshift-false (90.80s)
        --- PASS: kuttl/harness/listener_openshift-false (85.39s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-false (115.61s)
        --- PASS: kuttl/harness/tls-truststore_openshift-false_truststore-target-kind-Secret (7.48s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-3072_custom-secret-names-True (23.00s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-3072_custom-secret-names-False (19.70s)
PASS

@Maleware
Maleware marked this pull request as ready for review August 20, 2026 13:25
@Maleware Maleware self-assigned this Aug 20, 2026
@Maleware Maleware moved this to Development: Waiting for Review in Stackable Engineering Aug 20, 2026
@Maleware
Maleware requested a review from a team August 20, 2026 13:29

@sweb sweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd propose to change the title as the change does not explicitly drop the pvc but instead stops retrying so the claim gets dropped by mechanics that are already in place.

@Maleware

Copy link
Copy Markdown
Member Author

It reads drop pvc claims if not needed anymore I think it represents your wish as well :)

@Maleware
Maleware added this pull request to the merge queue Aug 21, 2026
@Maleware Maleware moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 21, 2026
Merged via the queue into main with commit dbb69f6 Aug 21, 2026
21 of 23 checks passed
@Maleware
Maleware deleted the fix/drop-pvc-if-not-existing-anymore branch August 21, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants