Skip to content

chore: Hint at restart buffer in too short cert lifetime error message - #741

Merged
sbernauer merged 1 commit into
mainfrom
chore/hint-at-restart-buffer
Aug 17, 2026
Merged

chore: Hint at restart buffer in too short cert lifetime error message#741
sbernauer merged 1 commit into
mainfrom
chore/hint-at-restart-buffer

Conversation

@sbernauer

Copy link
Copy Markdown
Member

https://stackable-workspace.slack.com/archives/C031NP72H7T/p1786970041382169

Description

No release notes needed

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Aug 17, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 17, 2026
@sbernauer sbernauer changed the title chore: Hint a restart buffer in too short cert lifetime error message chore: Hint at restart buffer in too short cert lifetime error message Aug 17, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be cool if it was automatic, but this helps.

@sbernauer
sbernauer added this pull request to the merge queue Aug 17, 2026
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Aug 17, 2026
@soenkeliebau

Copy link
Copy Markdown
Member

I think it makes sense to not have this automatic fwiw. Its a "soft but firm" recommendation against very short cert lifetimes, and having to tweak that parameter maybe makes users think about if they really want this :)

Merged via the queue into main with commit c47addc Aug 17, 2026
12 checks passed
@sbernauer
sbernauer deleted the chore/hint-at-restart-buffer branch August 17, 2026 13:22
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Aug 19, 2026
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants